Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump contract #65

Merged
merged 2 commits into from
Dec 2, 2024
Merged

chore: bump contract #65

merged 2 commits into from
Dec 2, 2024

Conversation

SebastianElvis
Copy link
Member

No description provided.

Copy link
Contributor

@maurolacy maurolacy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

v0.11.0-rc.1
16f615403c89b2a49a656ae199cd2ba19e963f00
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to bump this to current main (5f5ba8de0f04fc807a2c5683ab49235c8514cfc9).

Either that, or (better) tag / release a new v0.12.0-rc.0 of the contracts.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have something like circular deps here:

  1. babylon <- babylon-sdk (version / tag for docker)
  2. babylon-sdk <- babylon-contract (version / tag for contracts)
  3. babylon-contract <- babylon (submodule for protos)

Which is unfortunate, but kind of unavoidable at this point I guess.

Copy link
Contributor

@maurolacy maurolacy Dec 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sequence of versioning would be:

  1. Release new contracts version / tag. With the babylon submodule pointing to a babylon dev branch if necessary.
  2. Release a babylon-sdk version / tag with that contract version.
  3. Integrate that babylon sdk with babylon and other repos (integration, tests, etc.)
  4. Adjust / update the babylon submodule ref in babylon-contract to base/consumer-chain-support. (in main or in a new branch)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep we might need to start defining some release process, as well as cleaning the dependencies.

My current thinking is to follow phase-2's procedure where Babylon remains the root of the dependency. The process is then like releasing Babylon node -> releasing every peripheral program.

This requires us to move out all the e2e tests for integration from Babylon to Babylon SDK.

Wdyt we create a github issue for the release procedure, and then address it after moving out those e2e tests from Babylon?

@SebastianElvis SebastianElvis merged commit 411d4ac into main Dec 2, 2024
7 of 8 checks passed
@maurolacy maurolacy deleted the bump-contracts branch December 3, 2024 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants